Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, dbnu

Members: 1
Guests: 2
Stats
Files
Topics
Posts
Members
Newest Member
481
3,734
19,366
618
Micheal64X
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] Liquid mixture table ha...
Forum Rules | Mark all | Recent Posts

[Bug] Liquid mixture table has an array which is too small
< Newer Topic :: Older Topic > AFKMud 1.64

Pages:<< prev 1 next >>
Post is unread #1 Jan 22, 2005, 5:41 pm   Last edited Nov 13, 2005, 11:58 am by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: Liquid mixture table has an array which is too small.
Discovered in: AFKMud 1.64
Danger: High - Memory will be corrupted producing unpredictable results.
Found by: Samson
Fixed by: Samson

---

liquids.h,

Locate:

struct mixture_list
{
   MIX_TABLE *next;
   MIX_TABLE *prev;
   char *name;
   int  data [2];
   bool object;
};


Change to:

struct mixture_list
{
   MIX_TABLE *next;
   MIX_TABLE *prev;
   char *name;
   int  data [3];
   bool object;
};


The data field in the mixture struct is too small for the array. Data is loaded into this table at bootup and is also addable at any time in the game via OLC. Errors like this are very subtle, and often very difficult to spot even when using memory debugging software. The error may not even be noticed for months at a time. In this particular case, this error has existed for the life of the snippet code and has never been caught.

This bug also affects Noplex's liquid code and has been corrected there.
       
Pages:<< prev 1 next >>