Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing, Yandex

Members: 0
Guests: 3
Stats
Files
Topics
Posts
Members
Newest Member
481
3,734
19,366
618
Micheal64X
Today's Birthdays
Vintar (28)
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] do_mpforce performs uns...
Forum Rules | Mark all | Recent Posts

[Bug] do_mpforce performs unsafe removals from rooms
< Newer Topic :: Older Topic > AFKMud 1.64

Pages:<< prev 1 next >>
Post is unread #1 Jan 9, 2005, 11:45 am   Last edited Nov 13, 2005, 12:01 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: do_mpforce performs actions which may remove mobs/players from the room and fails to safeguard against this.
Discovered in: AFKMud 1.64
Danger: High - Potential crash bug + pointer corruption
Found by: Samson
Fixed by: Samson

---

mud_comm.c, do_mpforce:

Locate:

   if( !str_cmp( arg, "all" ) )
   {
      CHAR_DATA *vch;

      for( vch = ch->in_room->first_person; vch; vch = vch->next_in_room )
         if( get_trust( vch ) in_room->first_person; vch; vch = vch_next )
      {
         vch_next = vch->next_in_room;

         if( get_trust( vch ) < get_trust( ch ) && can_see( ch, vch, FALSE ) )
         {
            if( cmd && IS_CMD_FLAG( cmd, CMD_NOFORCE ) )
            {
               progbugf( ch, "Mpforce: Attempted to force all to %s - command is flagged noforce", arg2 );
               return;
            }
            interpret( vch, argument );
         }
      }
   }


Replace with:
   if( !str_cmp( arg, "all" ) )
   {
      CHAR_DATA *vch, *vch_next;

      for( vch = ch->in_room->first_person; vch; vch = vch_next )
      {
         vch_next = vch->next_in_room;

         if( get_trust( vch ) < get_trust( ch ) && can_see( ch, vch, FALSE ) )
         {
            if( cmd && IS_CMD_FLAG( cmd, CMD_NOFORCE ) )
            {
               progbugf( ch, "Mpforce: Attempted to force all to %s - command is flagged noforce", arg2 );
               return;
            }
            interpret( vch, argument );
         }
      }
   }


Because the do_mpforce command calls interpret() to peform forced actions on the victims, it is possible that the victim may die, be transferred to another location, or be otherwise removed from the room list the force command is being used in. This can lead to some serious corruption of pointer lists, and even game crashes.

This bug also affects other Smaug codebases in a similar manner.
       
Pages:<< prev 1 next >>