Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Yandex, Google

Members: 0
Guests: 5
Stats
Files
Topics
Posts
Members
Newest Member
481
3,734
19,366
618
Micheal64X
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] create_new_race is not ...
Forum Rules | Mark all | Recent Posts

[Bug] create_new_race is not properly allocating the where_name list
< Newer Topic :: Older Topic > AFKMud 1.64

Pages:<< prev 1 next >>
Post is unread #1 Jan 9, 2005, 1:16 am   Last edited Nov 13, 2005, 12:01 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: create_new_race is not properly allocating the where_name list
Discovered in: AFKMud 1.64
Danger: Medium - Memory error
Found by: Samson
Fixed by: Samson

---

act_wiz.c, create_new_race

Locate:

   for( i = 0; i where_name[i] = where_names[i];


Replace with:

   for( i = 0; i where_name[i] = STRALLOC( where_names[i] );


When a race entry is removed later for whatever reason, the wear_name tables will attempt to STRFREE the list. However if this race was created online and the MUD has not yet rebooted, there will be a memory leak created. The string hash table will also contain improper information as a result.

This bug also affects the Smaug codebase, except that in Smaug it is using DISPOSE to free the entries while never having properly allocated them, so the fix above will require the use of str_dup instead.
       
Pages:<< prev 1 next >>