Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Yandex, Google

Members: 0
Guests: 15
Stats
Files
Topics
Posts
Members
Newest Member
481
3,734
19,366
618
Micheal64X
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] Double freeing say_hist...
Forum Rules | Mark all | Recent Posts

[Bug] Double freeing say_history. Memory leak. tell_history not freed
< Newer Topic :: Older Topic > AFKMud 1.7

Pages:<< prev 1 next >>
Post is unread #1 May 17, 2005, 7:11 pm   Last edited Nov 13, 2005, 11:29 am by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: Double freeing say_history / Memory leak - tell_history not being DISPOSED
Discovered in: AFKMud 1.7
Danger: High - Potential for memory corruption and crashes
Found by: Samson
Fixed by: Samson

---

db.c, free_char

Locate:
      /*
       * Dammit! You forgot another one you git! 
       */
      for( x = 0; x < MAX_TELLHISTORY; x++ )
         DISPOSE( ch->pcdata->say_history[x] );


Change to:
      /*
       * Dammit! You forgot another one you git! 
       */
      for( x = 0; x < MAX_TELLHISTORY; x++ )
         DISPOSE( ch->pcdata->tell_history[x] );


As one can see, this is a double-whammie. Especially if for some reason MAX_TELLHISTORY isn't the same value as MAX_SAYHISTORY. Not only is double freeing memory a bad thing, it's even worse when the intended memory to be freed is never actually being freed. All in all, this is the kind of nasty crap that can plague you because of typos.
       
Pages:<< prev 1 next >>