Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing

Members: 0
Guests: 2
Stats
Files
Topics
Posts
Members
Newest Member
481
3,734
19,366
618
Micheal64X
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] do_promote allowed prom...
Forum Rules | Mark all | Recent Posts

[Bug] do_promote allowed promotion past MAX_LEVEL
< Newer Topic :: Older Topic > AFKMud 1.7

Pages:<< prev 1 next >>
Post is unread #1 May 6, 2005, 12:36 am   Last edited Nov 13, 2005, 11:31 am by Samson
Go to the top of the page
Go to the bottom of the page

Xorith
The Null Value
GroupAFKMud Team
Posts254
JoinedFeb 23, 2003

Bug: do_promote allowed promotion past MAX_LEVEL
Discovered in: AFKMud 1.7
Danger: Trivial - Another, unrelated ifcheck prevents this
Found By: Xorith
Fixed By: Xorith

--
act_wiz.c, do_promote

Locate the following:
level = victim->level + 1;


And change to:
level = victim->level + 1;
if( level > MAX_LEVEL )
{
   ch_printf( ch, "Cannot promote %s above the max level of %d.\n\r", victim->name, MAX_LEVEL );
   return;
}


Pretty much, the only way you'll feel this bug is if you allow the same level to promote. Then a level 115 (or whatever your max level is) could promote above 115 by one. While the current permissions check doesn't allow a 115 to promote someone equal to their rank, that doesn't mean this ifcheck should be neglected. Should you change the permissions, then there would be room for an error case.

       
Pages:<< prev 1 next >>