Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Yandex

Members: 0
Guests: 9
Stats
Files
Topics
Posts
Members
Newest Member
481
3,734
19,366
618
Micheal64X
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] Namegen code crashes if...
Forum Rules | Mark all | Recent Posts

[Bug] Namegen code crashes if no look description is set
< Newer Topic :: Older Topic > AFKMud 1.75

Pages:<< prev 1 next >>
Post is unread #1 Aug 26, 2005, 7:03 am   Last edited Nov 13, 2005, 11:08 am by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: Namegen code crashes if no look description is set.
Discovered in: AFKMud 1.75
Danger: Fatal - Will fail to boot up if the mob uses the namegen code.
Found by: Moonwolf
Fixed by: Samson

---

reset.c, reset_room

Locate:
               if( mob->chardesc )
                  tempStr3 = STRALLOC( mob->chardesc );
               STRFREE( mob->chardesc );
               while( tempStr3[0] != '\0' )
               {
                  tempStr3 = one_argument( tempStr3, temp );
                  if( !strcasecmp( temp, "namegen" ) )
                     mudstrlcat( tempStr4, nameg, MSL );
                  else
                  {
                     if( !strncasecmp( temp, "namegen", 7 ) )
                     {
                        for( x = 7; x < strlen( temp ); x++ )
                           temp[x - 7] = temp[x];

                        temp[strlen( temp ) - 7] = '\0';
                        mudstrlcat( tempStr4, nameg, MSL );
                        mudstrlcat( tempStr4, temp, MSL );
                     }
                     else
                        mudstrlcat( tempStr4, temp, MSL );
                  }
                  mudstrlcat( tempStr4, " ", MSL );
               }
               mob->chardesc = STRALLOC( tempStr4 );


Change all that to:
               if( mob->chardesc )
               {
                  tempStr3 = STRALLOC( mob->chardesc );
                  STRFREE( mob->chardesc );
                  while( tempStr3[0] != '\0' )
                  {
                     tempStr3 = one_argument( tempStr3, temp );
                     if( !strcasecmp( temp, "namegen" ) )
                        mudstrlcat( tempStr4, nameg, MSL );
                     else
                     {
                        if( !strncasecmp( temp, "namegen", 7 ) )
                        {
                           for( x = 7; x < strlen( temp ); x++ )
                              temp[x - 7] = temp[x];

                           temp[strlen( temp ) - 7] = '\0';
                           mudstrlcat( tempStr4, nameg, MSL );
                           mudstrlcat( tempStr4, temp, MSL );
                        }
                        else
                           mudstrlcat( tempStr4, temp, MSL );
                     }
                     mudstrlcat( tempStr4, " ", MSL );
                  }
                  mob->chardesc = STRALLOC( tempStr4 );
               }


The crash in this code comes from the "look desc" assigned to the mob. That is, the one you see when you type 'look mob' and get something back. The section of the code which handles replacements for namegen in look descriptions was not performing proper safety checks to make sure the mob actually had one.
       
Pages:<< prev 1 next >>