Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Yandex

Members: 0
Guests: 9
Stats
Files
Topics
Posts
Members
Newest Member
481
3,735
19,370
618
Micheal64X
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » General » Smaug Snippets » Pfile Snippet
Forum Rules | Mark all | Recent Posts

Pfile Snippet
< Newer Topic :: Older Topic > Memory leak

Pages:<< prev 1 next >>
Post is unread #1 Feb 11, 2004, 11:28 am   Last edited Nov 23, 2007, 11:52 pm by Samson
Go to the top of the page
Go to the bottom of the page

Greven
Magician
GroupMembers
Posts204
JoinedMar 5, 2005

I beleive that there is a memory leak in the pfile pruning snippet. While the various fields are read in with fread_string and assigned into clan, name, and I think deity, they are not freed. I beleive that something like this is need at the bottom of the function:
   if( deity != NULL )
   {
	DEITY_DATA *god = get_deity( deity );

	if( god )
         god->worshippers++;
   }
   
   if ( clan )
      STRFREE( clan );
   if ( name )
      STRFREE( name );
   if ( deity )
      STRFREE( deity );
   return;
I duno, maybe I'm insane...
       
Post is unread #2 Feb 11, 2004, 11:50 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Your not insane. Many of the snippets survived by making use of the existing infrastructure available in Smaug at the time and were often released before I had a clear understanding of memory leakage and such. When I get some time I'll go through and update these things. If you find more, post them
       
Post is unread #3 Feb 11, 2004, 11:53 am
Go to the top of the page
Go to the bottom of the page

Greven
Magician
GroupMembers
Posts204
JoinedMar 5, 2005

I've tested it, and it looks like that those are not the only leaks in the command, when I track it down I'll post the fix.
       
Post is unread #4 Feb 13, 2004, 11:06 am
Go to the top of the page
Go to the bottom of the page

Greven
Magician
GroupMembers
Posts204
JoinedMar 5, 2005

Well, it looks like the current version of the snippet, with the STRFREE's, should do the trick, the memory leaks I was still having involved modifications I had done, with a return that was ending the function early. The stock one should work just fine.
       
Pages:<< prev 1 next >>