Another one that I found recently. Not sure if someone was just really confused when they did this or what, but the more I looked, the less sense it made.
Original code is found in act_info.c, format_obj_to_char( )
if( ch->Class == CLASS_PALADIN
&& ( IS_OBJ_STAT( obj, ITEM_ANTI_EVIL ) && !IS_OBJ_STAT( obj, ITEM_ANTI_NEUTRAL )
&& !IS_OBJ_STAT( obj, ITEM_ANTI_GOOD ) ) )
mudstrlcat( buf, "(Flaming Red) ", MAX_STRING_LENGTH );
if( ch->Class == CLASS_PALADIN
&& ( !IS_OBJ_STAT( obj, ITEM_ANTI_EVIL ) && IS_OBJ_STAT( obj, ITEM_ANTI_NEUTRAL )
&& !IS_OBJ_STAT( obj, ITEM_ANTI_GOOD ) ) )
mudstrlcat( buf, "(Flaming Grey) ", MAX_STRING_LENGTH );
if( ch->Class == CLASS_PALADIN
&& ( !IS_OBJ_STAT( obj, ITEM_ANTI_EVIL ) && !IS_OBJ_STAT( obj, ITEM_ANTI_NEUTRAL )
&& IS_OBJ_STAT( obj, ITEM_ANTI_GOOD ) ) )
mudstrlcat( buf, "(Flaming White) ", MAX_STRING_LENGTH );
if( ch->Class == CLASS_PALADIN
&& ( IS_OBJ_STAT( obj, ITEM_ANTI_EVIL ) && IS_OBJ_STAT( obj, ITEM_ANTI_NEUTRAL )
&& !IS_OBJ_STAT( obj, ITEM_ANTI_GOOD ) ) )
mudstrlcat( buf, "(Smouldering Red-Grey) ", MAX_STRING_LENGTH );
if( ch->Class == CLASS_PALADIN
&& ( IS_OBJ_STAT( obj, ITEM_ANTI_EVIL ) && !IS_OBJ_STAT( obj, ITEM_ANTI_NEUTRAL )
&& IS_OBJ_STAT( obj, ITEM_ANTI_GOOD ) ) )
mudstrlcat( buf, "(Smouldering Red-White) ", MAX_STRING_LENGTH );
if( ch->Class == CLASS_PALADIN
&& ( !IS_OBJ_STAT( obj, ITEM_ANTI_EVIL ) && IS_OBJ_STAT( obj, ITEM_ANTI_NEUTRAL )
&& IS_OBJ_STAT( obj, ITEM_ANTI_GOOD ) ) )
mudstrlcat( buf, "(Smouldering Grey-White) ", MAX_STRING_LENGTH );
Am I crazy, or should that not be written like this instead?
if ( ch->Class==CLASS_PALADIN && ( IS_OBJ_STAT(obj, ITEM_ANTI_EVIL) && !IS_OBJ_STAT(obj, ITEM_ANTI_NEUTRAL) && !IS_OBJ_STAT(obj, ITEM_ANTI_GOOD)) )
mudstrlcat( buf, "(Smouldering Grey-White) ", MAX_STRING_LENGTH );
if ( ch->Class==CLASS_PALADIN && ( !IS_OBJ_STAT(obj, ITEM_ANTI_EVIL) && IS_OBJ_STAT(obj, ITEM_ANTI_NEUTRAL) && !IS_OBJ_STAT(obj, ITEM_ANTI_GOOD)) )
mudstrlcat( buf, "(Smouldering Red-White) ", MAX_STRING_LENGTH );
if ( ch->Class==CLASS_PALADIN && (!IS_OBJ_STAT(obj, ITEM_ANTI_EVIL) && !IS_OBJ_STAT(obj, ITEM_ANTI_NEUTRAL) && IS_OBJ_STAT(obj, ITEM_ANTI_GOOD)) )
mudstrlcat( buf, "(Smouldering Red-Grey) ", MAX_STRING_LENGTH );
if ( ch->Class==CLASS_PALADIN && ( IS_OBJ_STAT(obj, ITEM_ANTI_EVIL) && IS_OBJ_STAT(obj, ITEM_ANTI_NEUTRAL) && !IS_OBJ_STAT(obj, ITEM_ANTI_GOOD)) )
mudstrlcat( buf, "(Burning White) ", MAX_STRING_LENGTH );
if ( ch->Class==CLASS_PALADIN && ( IS_OBJ_STAT(obj, ITEM_ANTI_EVIL) && !IS_OBJ_STAT(obj, ITEM_ANTI_NEUTRAL) && IS_OBJ_STAT(obj, ITEM_ANTI_GOOD)) )
mudstrlcat( buf, "(Burning Grey) ", MAX_STRING_LENGTH );
if ( ch->Class==CLASS_PALADIN && ( !IS_OBJ_STAT(obj, ITEM_ANTI_EVIL) && IS_OBJ_STAT(obj, ITEM_ANTI_NEUTRAL) && IS_OBJ_STAT(obj, ITEM_ANTI_GOOD)) )
mudstrlcat( buf, "(Burning Red) ", MAX_STRING_LENGTH );