SmaugMuds.org
Files Forum Members Search Help Hierarchy AFKMud SmaugFUSS GDB Tutorial
Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Recent Posts
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
Pay for help? Formally labeled overland.c overland.h
May 2, 2018, 5:32 pm
By joeyfogas
Recent Uploads
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Top Posters
Samson (3644)
Remcon (1874)
Kayle (1195)
David Haley (903)
Conner (870)
Top Uploaders
Samson (158)
Kayle (133)
Hanaisse (36)
Gage (33)
Remcon (32)
Users Online
CommonCrawl, DotBot, Bing

Members: 0
Guests: 11
Stats
Files
Topics
Posts
Members
Newest Member 481
3,740
19,396
629
DarrenPayn Today's Birthdays
Noplex (33)
Related Links
» SmaugMuds.org » Codebases » SmaugFUSS » Bug in format_obj_to_char( )
Forum Rules | Mark all | Recent Posts

Bug in format_obj_to_char( )
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Jan 12, 2017, 1:27 am
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts396
JoinedMar 7, 2005

Another one that I found recently. Not sure if someone was just really confused when they did this or what, but the more I looked, the less sense it made. :blink:

Original code is found in act_info.c, format_obj_to_char( ) 

   if( ch->Class == CLASS_PALADIN
       && ( IS_OBJ_STAT( obj, ITEM_ANTI_EVIL ) && !IS_OBJ_STAT( obj, ITEM_ANTI_NEUTRAL )
            && !IS_OBJ_STAT( obj, ITEM_ANTI_GOOD ) ) )
      mudstrlcat( buf, "(Flaming Red) ", MAX_STRING_LENGTH );
   if( ch->Class == CLASS_PALADIN
       && ( !IS_OBJ_STAT( obj, ITEM_ANTI_EVIL ) && IS_OBJ_STAT( obj, ITEM_ANTI_NEUTRAL )
            && !IS_OBJ_STAT( obj, ITEM_ANTI_GOOD ) ) )
      mudstrlcat( buf, "(Flaming Grey) ", MAX_STRING_LENGTH );
   if( ch->Class == CLASS_PALADIN
       && ( !IS_OBJ_STAT( obj, ITEM_ANTI_EVIL ) && !IS_OBJ_STAT( obj, ITEM_ANTI_NEUTRAL )
            && IS_OBJ_STAT( obj, ITEM_ANTI_GOOD ) ) )
      mudstrlcat( buf, "(Flaming White) ", MAX_STRING_LENGTH );

   if( ch->Class == CLASS_PALADIN
       && ( IS_OBJ_STAT( obj, ITEM_ANTI_EVIL ) && IS_OBJ_STAT( obj, ITEM_ANTI_NEUTRAL )
            && !IS_OBJ_STAT( obj, ITEM_ANTI_GOOD ) ) )
      mudstrlcat( buf, "(Smouldering Red-Grey) ", MAX_STRING_LENGTH );
   if( ch->Class == CLASS_PALADIN
       && ( IS_OBJ_STAT( obj, ITEM_ANTI_EVIL ) && !IS_OBJ_STAT( obj, ITEM_ANTI_NEUTRAL )
            && IS_OBJ_STAT( obj, ITEM_ANTI_GOOD ) ) )
      mudstrlcat( buf, "(Smouldering Red-White) ", MAX_STRING_LENGTH );
   if( ch->Class == CLASS_PALADIN
       && ( !IS_OBJ_STAT( obj, ITEM_ANTI_EVIL ) && IS_OBJ_STAT( obj, ITEM_ANTI_NEUTRAL )
            && IS_OBJ_STAT( obj, ITEM_ANTI_GOOD ) ) )
      mudstrlcat( buf, "(Smouldering Grey-White) ", MAX_STRING_LENGTH );


Am I crazy, or should that not be written like this instead? :huh: 

    if ( ch->Class==CLASS_PALADIN && ( IS_OBJ_STAT(obj, ITEM_ANTI_EVIL) && !IS_OBJ_STAT(obj, ITEM_ANTI_NEUTRAL) && !IS_OBJ_STAT(obj, ITEM_ANTI_GOOD))   )
          mudstrlcat( buf, "(Smouldering Grey-White) ", MAX_STRING_LENGTH  );
    if ( ch->Class==CLASS_PALADIN && ( !IS_OBJ_STAT(obj, ITEM_ANTI_EVIL) && IS_OBJ_STAT(obj, ITEM_ANTI_NEUTRAL) && !IS_OBJ_STAT(obj, ITEM_ANTI_GOOD))   )
          mudstrlcat( buf, "(Smouldering Red-White) ", MAX_STRING_LENGTH  );
    if ( ch->Class==CLASS_PALADIN && (!IS_OBJ_STAT(obj, ITEM_ANTI_EVIL) && !IS_OBJ_STAT(obj, ITEM_ANTI_NEUTRAL) && IS_OBJ_STAT(obj, ITEM_ANTI_GOOD))   )
          mudstrlcat( buf, "(Smouldering Red-Grey) ", MAX_STRING_LENGTH  );
    if ( ch->Class==CLASS_PALADIN && ( IS_OBJ_STAT(obj, ITEM_ANTI_EVIL) && IS_OBJ_STAT(obj, ITEM_ANTI_NEUTRAL) && !IS_OBJ_STAT(obj, ITEM_ANTI_GOOD))   )
          mudstrlcat( buf, "(Burning White) ", MAX_STRING_LENGTH  );
    if ( ch->Class==CLASS_PALADIN && ( IS_OBJ_STAT(obj, ITEM_ANTI_EVIL) && !IS_OBJ_STAT(obj, ITEM_ANTI_NEUTRAL) && IS_OBJ_STAT(obj, ITEM_ANTI_GOOD))   )
          mudstrlcat( buf, "(Burning Grey) ", MAX_STRING_LENGTH  );
    if ( ch->Class==CLASS_PALADIN && ( !IS_OBJ_STAT(obj, ITEM_ANTI_EVIL) && IS_OBJ_STAT(obj, ITEM_ANTI_NEUTRAL) && IS_OBJ_STAT(obj, ITEM_ANTI_GOOD))   )
          mudstrlcat( buf, "(Burning Red) ", MAX_STRING_LENGTH  );


       
Post is unread #2 Jan 12, 2017, 3:02 pm
Go to the top of the page
Go to the bottom of the page

Sadiq
Fledgling
GroupMembers
Posts24
JoinedJan 7, 2010

I would make (and have made) this change. The rest of the SMAUG code traditionally uses the Red=Evil, Grey=Neutral, White=Good format, so this makes sense. Implemented. :wink:
       
Post is unread #3 Jan 12, 2017, 4:38 pm
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts396
JoinedMar 7, 2005


Sadiq said:

I would make (and have made) this change. The rest of the SMAUG code traditionally uses the Red=Evil, Grey=Neutral, White=Good format, so this makes sense. Implemented. :wink:


I knew I wasn't crazy! Thanks for the confirmation. :cyclops:
       
Post is unread #4 Jan 13, 2017, 10:01 am
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,874
JoinedJul 26, 2005

thanks while i had changed the whole look of that stuff because of how confusing it looked i hadn't paid the stuff it showed any attention, modified it :)
       
Pages:<< prev 1 next >>