Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 parse description bug
Today, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Google, Remcon, Yahoo!, DotBot

Members: 1
Guests: 12
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SmaugFUSS » SmaugFUSS 1.9.2
Forum Rules | Mark all | Recent Posts

SmaugFUSS 1.9.2
< Newer Topic :: Older Topic > Maintenance

Pages:<< prev 1 next >>
Post is unread #1 Nov 21, 2014, 7:14 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

SmaugFUSS 1.9.2 is released.

This is a minor maintenance release covering new issues fixed since 1.9.1. It should take care of everything in the forums that had been reported but not yet dealt with by 1.9.1.

Commit details are available here: https://github.com/Arthmoor/SmaugFUSS

Changes For SmaugFUSS 1.9.2

New Additions/Changes

Despite being specified in the code, the alignment antis were never implemented, and the class antis for Nephandi and Savage had not yet been added.

Bug Fixes

Setting all skills to 100 on a player does not properly handle adept maximization.
The mudprog_driver function to pick a random player as a target in a room had a very strong statistical bias in favor of the first chosen victim. The routine has now been corrected to do a proper random pick.
Mobs fleeing during mobile_update are not checking the ACT_STAY_AREA and can end up in areas they aren't allowed to move in, thus becoming stuck.
Due to a botched understanding of how door randomizer resets work, it was not possible to add one in the OLC.
Weather echo messages were still being delivered to people in indoor sector types.
Mobs who have the pass door effect on them never actually attempt to use it because the flags were not being checked.
It was possible to look at the sky while in an indoor sector.
is_name_prefix in handler.c did not match the definition specified in mud.h.
mpoload does not properly drop items to the ground that are loaded by object or room progs.
A memory leak was fixed in polymorph.c when reading morph data from a player file.
__FUNCTION__ is apparently not a portable method for embedding a function name. All instances have been swapped with __func__ instead.
Out of bounds array check in scramble() fixed.
Invalid bitflag check in do_oset() for trap flags fixed.
Wrong buffer size being used for IMC chess sessions in do_chess.
Memory leak in fread_memberlist() if the function drops out the bottom of the for loop for some reason.
Improper bounds checking for some loops involving static buffers.
Possible double free in load_projects if fread_project closed the file pointer before returning.
Bogus condition check for 'U' sectors (SECT_DUNNO) removed in add_new_room_to_map. 'U' is valid for SECT_UNDERWATER.
Memory leak in do_renumber if r_area is valid and check_vnums returns true.
Other minor issues pointed out by a CPPCheck analysis fixed. Not very many.
       
Post is unread #2 Nov 22, 2014, 10:23 pm
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts367
JoinedMar 7, 2005

Thanks again Samson. Some of this stuff I've already fixed, apparently, like the weather messages and pass_door stuff and looking at the sky, but what made this update the most helpful was it helped me catch the one piece I was missing with the alignment antis. Everything else seems to have been in place for a while, but the do_wear( ) check was still missing somehow. :facepalm:

Great catches and thanks again for sharing the details.
       
Post is unread #3 Nov 24, 2014, 3:17 am
Go to the top of the page
Go to the bottom of the page

Quixadhal
Conjurer
GroupMembers
Posts398
JoinedMar 8, 2005

Don't forget to update the VERSION file to 1.9.2! :)

I know it's annoying, but it has two purposes. One is that it reminds you to also make a tag, so 5 years from now when somebody wants to compares stock 1.9.2 against something else, they can just checkout the tag instead of trying to look up the big long hex string commit ID. The other is that it's the quickest and easiest way to see what version the repository is at, and thus know if you want to merge changes into your local stuff or not.

Nice work, BTW!
       
Post is unread #4 Nov 24, 2014, 11:13 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Ah, ok. Should be updated to 1.9.2 on my fork, will be in when Kayle gets the notification.

Not sure how we're handling the tagging for releases though since I don't have that kind of access on the mater repository.
       
Post is unread #5 Nov 25, 2014, 5:12 am
Go to the top of the page
Go to the bottom of the page

Quixadhal
Conjurer
GroupMembers
Posts398
JoinedMar 8, 2005

I have an automated line to generate the VERSION file....

        NEW="1.9.2"
        RECENT=`find "$NEW" -type f -printf '%TY-%Tm-%Td %TT %p\n' | grep -v .git | colrm 20 | sort -r | head -1`
        touch -d "$RECENT" "$NEW"
        for j in `find "$NEW" -type d -empty`; do
            touch -d "$RECENT" "$j/.gitignore"
        done
        echo -en "$NEW\t$RECENT\n" >"$NEW/VERSION"
        touch -d "$RECENT" "$NEW/VERSION"


I do most of my work in bash, so after cloning a local repo, I do my changes and run the above code and then commit locally. Then I do a "git tag $NEW", followed by "git push --all" and "git push --tags".

If you work in the top level, replace the $NEW in most of the lines above with ".", if you like. :)
       
Post is unread #6 Dec 5, 2014, 6:54 pm
Go to the top of the page
Go to the bottom of the page

Aurin
Magician
GroupMembers
Posts189
JoinedSep 5, 2010

Samson said:

SmaugFUSS 1.9.2 is released.

Bug Fixes
The mudprog_driver function to pick a random player as a target in a room had a very strong statistical bias in favor of the first chosen victim. The routine has now been corrected to do a proper random pick.

In regards to the comments on this within the code, I'm a guy. :facepalm:

Also, I do like how you have it simplified. I hadn't been in the coding side of things for that long when I made my fix. lol Happy there is a more reliable way to do it.
       
Post is unread #7 Dec 5, 2014, 8:16 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Oh, heh, I'll fix the comment. :P

Not sure if there was actually a problem with what you wrote, but it seemed dodgy to me so I tweaked it. Either way, thanks.
       
Pages:<< prev 1 next >>