Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Google

Members: 0
Guests: 13
Stats
Files
Topics
Posts
Members
Newest Member
481
3,739
19,386
619
Alexander
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SmaugFUSS » Bug: do_look does not check s...
Forum Rules | Mark all | Recent Posts

Bug: do_look does not check sector type for weather
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Feb 18, 2012, 11:59 pm
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts392
JoinedMar 7, 2005

Along the same lines as the last bug, there is no check for sector type in this block of do_look, from act_info.c:

   if( !str_cmp( arg1, "sky" ) || !str_cmp( arg1, "stars" ) )
   {
      if( !IS_OUTSIDE( ch ) )
         send_to_char( "You can't see the sky indoors.\r\n", ch );
      else
         look_sky( ch );

      return;
   }


Probably should be something like this. I would change the failure message too, since it isn't necessarily going to be indoors, but perhaps underwater/oceanfloor, etc.:

   if( !str_cmp( arg1, "sky" ) || !str_cmp( arg1, "stars" ) )
   {
      if( !IS_OUTSIDE( ch ) || NO_WEATHER_SECT( ch->in_room->sector_type ) )
         send_to_char( "You can't see the sky from here.\r\n", ch );
      else
         look_sky( ch );

      return;
   }
       
Pages:<< prev 1 next >>