Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, DotBot, Yahoo!

Members: 0
Guests: 7
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SmaugFUSS » Bug: do_look does not check s...
Forum Rules | Mark all | Recent Posts

Bug: do_look does not check sector type for weather
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Feb 18, 2012, 11:59 pm
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts367
JoinedMar 7, 2005

Along the same lines as the last bug, there is no check for sector type in this block of do_look, from act_info.c:

   if( !str_cmp( arg1, "sky" ) || !str_cmp( arg1, "stars" ) )
   {
      if( !IS_OUTSIDE( ch ) )
         send_to_char( "You can't see the sky indoors.\r\n", ch );
      else
         look_sky( ch );

      return;
   }


Probably should be something like this. I would change the failure message too, since it isn't necessarily going to be indoors, but perhaps underwater/oceanfloor, etc.:

   if( !str_cmp( arg1, "sky" ) || !str_cmp( arg1, "stars" ) )
   {
      if( !IS_OUTSIDE( ch ) || NO_WEATHER_SECT( ch->in_room->sector_type ) )
         send_to_char( "You can't see the sky from here.\r\n", ch );
      else
         look_sky( ch );

      return;
   }
       
Pages:<< prev 1 next >>