Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Yandex, Bing, DotBot

Members: 0
Guests: 13
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,396
629
DarrenPayn
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SmaugFUSS » Bug: time_update does not che...
Forum Rules | Mark all | Recent Posts

Bug: time_update does not check sector type
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Feb 18, 2012, 11:53 pm
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts396
JoinedMar 7, 2005

So was play testing and caught messages indoors / underwater and elsewhere about the time of day updates and started wondering if I broke something. Turns out this is a bug in the stock code, which despite the new weather system, is still retained to my knowledge.

In update.c, in function time_update, you'll find this:

if( d->connected == CON_PLAYING && IS_OUTSIDE( d->character ) && IS_AWAKE( d->character ) )


That should probably be something like this, which is how the original weather_update( ) used to work, so I think the inconsistency was just an oversight:

if( d->connected == CON_PLAYING && IS_OUTSIDE( d->character ) 
&& !NO_WEATHER_SECT( d->character->in_room->sector_type )
&& IS_AWAKE( d->character ) )


That should take care of it.
       
Post is unread #2 Feb 19, 2012, 6:14 am
Go to the top of the page
Go to the bottom of the page

Aurin
Magician
GroupMembers
Posts189
JoinedSep 5, 2010

Thanks! Was wondering where to make this update, though it was low on my bug list for fixing. heh
       
Post is unread #3 Feb 19, 2012, 1:03 pm
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,874
JoinedJul 26, 2005

and yet another nice catch :)
       
Pages:<< prev 1 next >>