Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Google, Yandex, Remcon

Members: 1
Guests: 13
Stats
Files
Topics
Posts
Members
Newest Member
481
3,735
19,370
618
Micheal64X
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SWFOTE FUSS » Bad code in act_comm.c do_ret...
Forum Rules | Mark all | Recent Posts

Bad code in act_comm.c do_retune
< Newer Topic :: Older Topic > I <3 Eleven

Pages:<< prev 1 next >>
Post is unread #1 Oct 17, 2011, 11:14 pm   Last edited Oct 17, 2011, 11:20 pm by ayuri
Go to the top of the page
Go to the bottom of the page

ayuri
Magician
GroupMembers
Posts239
JoinedJun 13, 2008

So, working on my conversion process and I found this gem in act_comm.c function do_retune:
      if( !str_cmp( argument, "111.111" ) && str_cmp( ch->name, "Eleven" ) )
      {
         send_to_char( "No. Heh.\r\n", ch );
         return;
      }


I think that should be removed from all future releases. Its locking out that 'frequency' to normal players who try to retune exactly to it.

**EDIT:
Also while we are at it, I'd suggest replacing in the same function:
      if( ch->main_ability != SLICER_ABILITY )
      {
         send_to_char( "You have absolutely no idea how to tune to a specific frequency.\r\n", ch );
         return;
      }
      if( ch->skill_level[SLICER_ABILITY] < 20 )
      {
         send_to_char( "You can't quite figure out how to do that yet.\r\n", ch );
         return;
      }


To

                if(ch->skill_level[SLICER_ABILITY] < 30)
                {
                        send_to_char("You can't quite figure out how to do that yet.\n\r", ch);
                        return;
                }


I don't see why the game should prevent someone from retuning their comlink if they have the required 'level' in slicer rather than making it a main ability.
If we are checking for main ability, then someone who picks combat first, and slicer second won't be able to retune to an exact frequency, or perhaps someone who spent a boat load of rp points to level up to level 30 slicer.

ayuri
       
Post is unread #2 Oct 18, 2011, 6:33 am
Go to the top of the page
Go to the bottom of the page

Kayle
Off the Edge of the Map
GroupAdministrators
Posts1,195
JoinedMar 21, 2006

The first one I can see changing. The second one though I don't feel comfortable changing as that's making a gameplay decision for people. If you wanted to change it so that it checks the secondary ability as well, I'd be okay with that.
       
Post is unread #3 Oct 18, 2011, 6:53 am
Go to the top of the page
Go to the bottom of the page

ayuri
Magician
GroupMembers
Posts239
JoinedJun 13, 2008

Getting it to check for main and secondary would be good enough. I just don't think it should say main ability only.

ayuri
       
Pages:<< prev 1 next >>