Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing, Sogou

Members: 0
Guests: 16
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
634
BlaineNock
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Weather system uses cop...
Forum Rules | Mark all | Recent Posts

[Bug] Weather system uses copy of old URANGE macro
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 10, 2010, 4:40 pm
Go to the top of the page
Go to the bottom of the page

Kayle
Off the Edge of the Map
GroupAdministrators
Posts1,195
JoinedMar 21, 2006

Bug: Weather system uses copy of old URANGE macro.
Danger: Medium - Could result in bogus math and things returning wrong..
Found by: Kayle
Fixed by: Kayle

---

weather.h

Find and remove the WRANGE macro.

weather.c, ApplyDeltaChanges
Find:
         //Here we actually apply the changes making sure they stay within specific bounds
         cell->temperature	= WRANGE( -30, cell->temperature + delta->temperature, 100 );
         cell->pressure		= WRANGE( 0, cell->pressure + delta->pressure, 100 );
         cell->cloudcover    = WRANGE( 0, cell->cloudcover + delta->cloudcover, 100 );
         cell->energy		= WRANGE( 0, cell->energy + delta->energy, 100 );
         cell->humidity		= WRANGE( 0, cell->humidity + delta->humidity, 100 );
         cell->precipitation = WRANGE( 0, cell->precipitation + delta->precipitation, 100 );
         cell->windSpeedX	= WRANGE( -100, cell->windSpeedX + delta->windSpeedX, 100 );
         cell->windSpeedY	= WRANGE( -100, cell->windSpeedY + delta->windSpeedY, 100 );


Replace with:
         //Here we actually apply the changes making sure they stay within specific bounds
         cell->temperature = URANGE( -30, cell->temperature + delta->temperature, 100 );
         cell->pressure = URANGE( 0, cell->pressure + delta->pressure, 100 );
         cell->cloudcover = URANGE( 0, cell->cloudcover + delta->cloudcover, 100 );
         cell->energy = URANGE( 0, cell->energy + delta->energy, 100 );
         cell->humidity = URANGE( 0, cell->humidity + delta->humidity, 100 );
         cell->precipitation = URANGE( 0, cell->precipitation + delta->precipitation, 100 );
         cell->windSpeedX = URANGE( -100, cell->windSpeedX + delta->windSpeedX, 100 );
         cell->windSpeedY = URANGE( -100, cell->windSpeedY + delta->windSpeedY, 100 );


This was an attempt to make the system as reliant on the codebase as possible but ended up just causing issues. So we'll just avoid those issues by using the urange call from the codebase.
       
Pages:<< prev 1 next >>