Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, DotBot, Google

Members: 0
Guests: 2
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
Evoru (32)
Related Links
» SmaugMuds.org » Bugfix Lists » SWR FUSS Bugfix List » [Bug] Characters not saved in...
Forum Rules | Mark all | Recent Posts

[Bug] Characters not saved in do_clan_withdraw/do_clan_donate.
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Feb 4, 2010, 10:04 pm
Go to the top of the page
Go to the bottom of the page

Kayle
Off the Edge of the Map
GroupAdministrators
Posts1,195
JoinedMar 21, 2006

Bug: Characters not saved in do_clan_withdraw/do_clan_donate
Danger: Medium - Could possibly be abused to drain or inflate a clans funds.
Found by: Caius
Fixed by: Kayle

---

clans.c, do_clan_withdraw
Find:
clan->funds -= amount;
   ch->gold += amount;
   save_clan( clan );


Replace with:
clan->funds -= amount;
   ch->gold += amount;
   save_char_obj( ch );


clans.c, do_clan_donate
Find:
clan->funds += amount;
   ch->gold -= amount;
   save_clan( clan );


Replace with:
clan->funds += amount;
   ch->gold -= amount;
   save_char_obj( ch );


save_char_obj will save the character, and will call save_clan. So this kills two birds with one stone.


       
Pages:<< prev 1 next >>