Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, DotBot

Members: 0
Guests: 16
Stats
Files
Topics
Posts
Members
Newest Member
481
3,739
19,386
627
MargoThurb
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SWR FUSS » Memory leaks in fread_planet()
Forum Rules | Mark all | Recent Posts

Memory leaks in fread_planet()
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 20, 2009, 10:09 am
Go to the top of the page
Go to the bottom of the page

Caius
Magician
GroupMembers
Posts132
JoinedJan 29, 2006

In fread_planet, under "GovernedBy" the return value of fread_string() is fed directly into get_clan().

if( !str_cmp( word, "GovernedBy" ) )
{
  planet->governed_by = get_clan( fread_string( fp ) );
  fMatch = TRUE;
}


Since fread_string() STRALLOCs it, this memory is never freed. A possible solution is rewriting it as such:

if( !str_cmp( word, "GovernedBy" ) )
{
  char *clan_name = fread_string( fp );
  planet->governed_by = get_clan( clan_name );
  fMatch = TRUE;
  STRFREE( clan_name );
}


The same applies to "Starsystem" a few lines below.
       
Post is unread #2 Dec 8, 2009, 3:26 am
Go to the top of the page
Go to the bottom of the page

Caius
Magician
GroupMembers
Posts132
JoinedJan 29, 2006

Seems like this was already reported in this thread. Sowwy...
       
Pages:<< prev 1 next >>