Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Yandex, Bing

Members: 0
Guests: 6
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SWFOTE FUSS » Setplanet filname has no chec...
Forum Rules | Mark all | Recent Posts

Setplanet filname has no checks
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Dec 17, 2008, 7:52 am
Go to the top of the page
Go to the bottom of the page

Keberus
Conjurer
GroupFUSS Project Team
Posts341
JoinedJun 4, 2005

This one fixes 2 problems, 1) you could set the filename to nothing, and 2) you could set to planets with the same filename, therefore corrupting data or at least overwriting one of them.

in planets.c do_setplanet find:
   if( !strcmp( arg2, "filename" ) )
   {
      DISPOSE( planet->filename );
      planet->filename = str_dup( argument );
      send_to_char( "Done.\r\n", ch );
      save_planet( planet );
      write_planet_list(  );
      return;
   }


and change to:
   if( !strcmp( arg2, "filename" ) )
   {
      PLANET_DATA *tplanet;

      if( !argument || argument[0] == '\0' )
      {
         send_to_char( "You must choose a file name.\r\n", ch );
         return;
      }
      for( tplanet = first_planet; tplanet; tplanet = tplanet->next )
      {
          if( !str_cmp( tplanet->filename, argument ) )
          {
              send_to_char( "A planet with that filename already exists!\r\n", ch );
              return;
          }
      }

      DISPOSE( planet->filename );
      planet->filename = str_dup( argument );
      send_to_char( "Done.\r\n", ch );
      save_planet( planet );
      write_planet_list(  );
      return;
   }
       
Pages:<< prev 1 next >>