Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex

Members: 0
Guests: 5
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
613
bastian
Today's Birthdays
Evoru (32)
Related Links
» SmaugMuds.org » Codebases » SWFOTE FUSS » 2 memory mismatch errors in f...
Forum Rules | Mark all | Recent Posts

2 memory mismatch errors in fread_sysdata
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Dec 17, 2008, 2:33 am
Go to the top of the page
Go to the bottom of the page

Keberus
Conjurer
GroupFUSS Project Team
Posts341
JoinedJun 4, 2005

in db.c the function fread_sysdata
            KEY( "Guildoverseer", sys->guild_overseer, fread_string( fp ) );
            KEY( "Guildadvisor", sys->guild_advisor, fread_string( fp ) );


should be (to match everywhere else)
            KEY( "Guildoverseer", sys->guild_overseer, fread_string_nohash( fp ) );
            KEY( "Guildadvisor", sys->guild_advisor, fread_string_nohash( fp ) );


No biggie, but its still a mismatch
       
Post is unread #2 Dec 17, 2008, 8:48 am
Go to the top of the page
Go to the bottom of the page

David Haley
Sorcerer
GroupMembers
Posts903
JoinedJan 29, 2007

Actually it could be a biggie, if somebody tried to free those using the wrong routine it could crash the game. Good catch.
       
Post is unread #3 Dec 17, 2008, 1:24 pm
Go to the top of the page
Go to the bottom of the page

Keberus
Conjurer
GroupFUSS Project Team
Posts341
JoinedJun 4, 2005

DavidHaley said:

Actually it could be a biggie, if somebody tried to free those using the wrong routine it could crash the game. Good catch.


Hmm, I thought the DISPOSE and STRFREE macros had protection against that built in? Where before anything is done the hash table is checked. It's all good at any rate.
       
Post is unread #4 Dec 17, 2008, 5:39 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

The protection on those macros only works with a C++ base. So the Star Wars code never got it.
       
Post is unread #5 Dec 18, 2008, 6:39 am
Go to the top of the page
Go to the bottom of the page

Keberus
Conjurer
GroupFUSS Project Team
Posts341
JoinedJun 4, 2005

Hmm, I guess it must've been a perk for switching to g++ early on then. Well I definitly reccomend the new macros get put in SWRfuss and SWfotefuss then, because they are hella nice, and make it easy to catch some of those memory mismatches.
       
Pages:<< prev 1 next >>