Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl

Members: 0
Guests: 16
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
633
Rhyader
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Improper comparison che...
Forum Rules | Mark all | Recent Posts

[Bug] Improper comparison checks in do_weather command
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 5, 2008, 5:23 pm   Last edited Oct 6, 2008, 5:40 am by Kayle
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: Improper comparison checks in do_weather command
Danger: Low, Causes undesirable messages to be shown with the weather command.
Found by: GCC 4.3
Fixed by: Samson

---

weather.c, do_weather

Locate:
if( getWindX( cell ) != 0 && getWindY != 0 )


Change to:
if( getWindX( cell ) != 0 && getWindY( cell ) != 0 )


Locate:
else if( getWindX( cell ) != 0 && getWindY == 0 )


Change to:
else if( getWindX( cell ) != 0 && getWindY( cell ) == 0 )


Locate:
else if( getWindX( cell ) == 0 && getWindY != 0 )


Change to:
else if( getWindX( cell ) == 0 && getWindY( cell ) != 0 )


GCC 4.3 issues a compiler warning when trying to compile SmaugFUSS 1.9:
cc1plus: warnings being treated as errors
weather.c: In function 'void do_weather(CHAR_DATA*, const char*)':
weather.c:3278: error: the address of 'int getWindY(WeatherCell*)' will never be NULL
weather.c:3333: error: the address of 'int getWindY(WeatherCell*)' will never be NULL
weather.c:3361: error: the address of 'int getWindY(WeatherCell*)' will never be NULL


Previous versions of GCC do not pick up this warning and it's likely this mistake has been causing some unintended results, though since I've not really played with the weather code I'm not sure what the mistake actually affects other than possibly displaying an incorrect wind message to the players.

[Edit:] Adjusted the Danger, And yeah, no real effect other than showing the wrong messages. And once again we find one of those little stupid errors that you get when you write complex systems in the wee hours of the morning. ;)
       
Pages:<< prev 1 next >>