Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing

Members: 0
Guests: 13
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
633
Rhyader
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Disenchant weapon crash...
Forum Rules | Mark all | Recent Posts

[Bug] Disenchant weapon crashes the game when cast
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 20, 2008, 1:29 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: Disenchant weapon crashes the game when cast
Danger: Critical - Game crash.
Found by: Kayle
Fixed by: Remcon

---

magic.c, spell_disenchant_weapon

Locate:
   for( paf = obj->first_affect; paf; paf = paf->next )
   {
      paf_next = paf->next;
      if( paf->location == APPLY_HITROLL || paf->location == APPLY_DAMROLL )
      {
         UNLINK( paf, obj->first_affect, obj->last_affect, next, prev );
         DISPOSE( paf );
      }
   }


Change to:
   for( paf = obj->first_affect; paf; paf = paf_next )
   {
      paf_next = paf->next;
      if( paf->location == APPLY_HITROLL || paf->location == APPLY_DAMROLL )
      {
         UNLINK( paf, obj->first_affect, obj->last_affect, next, prev );
         DISPOSE( paf );
      }
   }


This is one of those classic "oops" moments where the list is being manipulated incorrectly. The proper fix was even being kept in mind, it's just too bad that the for loop wasn't using it.
       
Pages:<< prev 1 next >>