Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Sogou

Members: 0
Guests: 11
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] DNS resolver code leave...
Forum Rules | Mark all | Recent Posts

[Bug] DNS resolver code leaves zombie processes behind
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Feb 17, 2008, 8:01 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: DNS caching code leaves zombie processes behind
Danger: Low - Generally not a problem unless there are tight restrictions on the number of processes allowed to run.
Found by: Zeno
Fixed by: Kasji

---

comm.c

Locate:
/*
 * LAG alarm!							-Thoric
 */
void caught_alarm( int signum )


Above that, add:
int child_exit_status = 0;

static void clean_up_child_process( int signal_number )
{
   /* Clean up the child process. */
   int status;
   wait( &status );

   /* Store its exit status in a global variable. */
   child_exit_status = status;
}


comm.c, game_loop

Locate:
#ifndef WIN32
   signal( SIGPIPE, SIG_IGN );
   signal( SIGALRM, caught_alarm );
#endif


Change to:
#ifndef WIN32
   signal( SIGPIPE, SIG_IGN );
   signal( SIGALRM, caught_alarm );
   signal( SIGCHLD, clean_up_child_process );
#endif


dns.c, process_dns

Locate and remove:
   int status;


Locate and remove:
   /*
    * we don't have to check here, 
    * cos the child is probably dead already. (but out of safety we do)
    * 
    * (later) I found this not to be true. The call to waitpid( ) is
    * necessary, because otherwise the child processes become zombie
    * and keep lingering around... The waitpid( ) removes them.
    */
   if( d->ipid != -1 )
   {
      waitpid( d->ipid, &status, 0 );
      d->ipid = -1;
   }


Apparently despite having protection against hanging zombie processes, they are still possible to generate. This fix more or less just rearranges the order of things to prevent the zombies from happening.
       
Pages:<< prev 1 next >>