Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Majestic-12, DotBot

Members: 0
Guests: 16
Stats
Files
Topics
Posts
Members
Newest Member
481
3,739
19,386
625
OmarHarrim
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Chess games don't clean...
Forum Rules | Mark all | Recent Posts

[Bug] Chess games don't clean up properly when one player quits
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Nov 11, 2007, 11:13 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: Chess games don't clean up properly when one player quits
Danger: High - Crash bug. If the other game player tries to end the game, the MUD crashes.
Found by: Findecano
Fixed by: Findecano

---

chess.c, free_game

Locate the function and replace it with:
void free_game( GAME_BOARD_DATA * board )
{
   if( !board )
      return;

#ifdef IMC
   if( board->type == TYPE_IMC )
   {
      imc_send_chess( board->player1 ? board->player1 : NULL, board->player2, "stop" );
      STRFREE( board->player2 );
   }
#endif

   if( board->player1 )
   {
      if( CHAR_DATA *ch = get_char_world( supermob, board->player1 ) ) // Added for bugfix - Findecano 23/11/07
      {
         ch_printf( ch, "The game has been stopped at %d total moves.\r\n", board->turn );
         ch->pcdata->game_board = NULL;
      }
   }

   if( board->player2 )
   {
      if( CHAR_DATA *ch = get_char_world( supermob, board->player2 ) ) // Added for bugfix - Findecano 23/11/07
      {
         ch_printf( ch, "The game has been stopped at %d total moves.\r\n", board->turn );
         ch->pcdata->game_board = NULL;
      }
   }
   STRFREE( board->player1 );
   STRFREE( board->player2 );
   DISPOSE( board );
}


When someone quits in the middle of a chess game, the code for stopping the game via "chess cease" did not have any safety checks against NULL participants. It would then crash the MUD when trying to send messages to invalid targets.
       
Pages:<< prev 1 next >>