Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, DotBot

Members: 0
Guests: 12
Stats
Files
Topics
Posts
Members
Newest Member
481
3,739
19,386
627
MargoThurb
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Remove spells get appli...
Forum Rules | Mark all | Recent Posts

[Bug] Remove spells get applied when wearing an item
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 14, 2007, 11:42 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: Remove spells get applied when wearing an item
Danger: Low - Has the opposite affect of what's expected.
Found by: Remcon
Fixed by: Remcon

---

handler.c, affect_modify

Locate:
      case APPLY_WEARSPELL:
      case APPLY_REMOVESPELL:
         if( xIS_SET( ch->in_room->room_flags, ROOM_NO_MAGIC ) || IS_SET( ch->immune, RIS_MAGIC )
          || ( ( paf->location % REVERSE_APPLY ) == APPLY_WEARSPELL && !fAdd )
          || ( ( paf->location % REVERSE_APPLY ) == APPLY_REMOVESPELL && !fAdd )
          || saving_char == ch   /* so save/quit doesn't trigger */
          || loading_char == ch )   /* so loading doesn't trigger */
            return;


Change to:
      case APPLY_WEARSPELL:
      case APPLY_REMOVESPELL:
         if( xIS_SET( ch->in_room->room_flags, ROOM_NO_MAGIC ) || IS_SET( ch->immune, RIS_MAGIC )
          || ( ( paf->location % REVERSE_APPLY ) == APPLY_WEARSPELL && !fAdd )
          || ( ( paf->location % REVERSE_APPLY ) == APPLY_REMOVESPELL && fAdd )
          || saving_char == ch   /* so save/quit doesn't trigger */
          || loading_char == ch )   /* so loading doesn't trigger */
            return;


A subtle but important detail. Unfixed, a removespell would actually apply its affects to the player when the item was worn, not when it was removed as it should be.
       
Pages:<< prev 1 next >>