Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing

Members: 0
Guests: 29
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
635
JenniRosen
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Crash when mobs attempt...
Forum Rules | Mark all | Recent Posts

[Bug] Crash when mobs attempt to perform some skills
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 14, 2007, 11:41 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: Crash when mobs attempt to perform some skills
Danger: High - Game crash.
Found by: Valcados
Fixed by: Valcados

---

magic.c, ch_slookup

Locate:
   // Make sure that:
   // (a) ch knows this skill
   // and, (b) ch's level is high enough
   if( ch->pcdata->learned[sn] > 0
       && ( ch->level >= skill_table[sn]->skill_level[ch->Class] || ch->level >= skill_table[sn]->race_level[ch->race] ) )
   {
      return sn;
   }
   else
   {
      // nope... ch doesn't have this skill.
      return -1;
   }


Change to:
   // Make sure that:
   // (a) ch knows this skill
   // and, (b) ch's level is high enough
   if( IS_NPC(ch) )
      return sn;
   if( ch->pcdata->learned[sn] > 0
       && ( ch->level >= skill_table[sn]->skill_level[ch->Class] || ch->level >= skill_table[sn]->race_level[ch->race] ) )
   {
      return sn;
   }
   else
   {
      // nope... ch doesn't have this skill.
      return -1;
   }


The main reason for this causing a crash is because the function relies on the subject being a player - but the code has NPCs also perform skill moves at times and since NPCs don't have a pcdata pointer, the added safeguard is necessary.
       
Pages:<< prev 1 next >>