User Name:


Forgot your password?
Vote for Us!
adding a new stat to OSET
Mar 18, 2018, 6:02 pm
By joeyfogas
alias snippet fix-like hack
Mar 17, 2018, 6:14 pm
By Vladaar
help with debug?
Mar 17, 2018, 5:52 pm
By joeyfogas
features of a good MUD
Mar 17, 2018, 1:06 am
By GatewaySysop
All skills to a class?
Mar 15, 2018, 11:43 pm
By joeyfogas
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, DotBot, Yandex, Bing

Members: 0
Guests: 5
Newest Member
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWR FUSS Bugfix List » [Bug] Improper damage message...
Forum Rules | Mark all | Recent Posts

[Bug] Improper damage messages from dam_message
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 14, 2007, 11:12 am
Go to the top of the page
Go to the bottom of the page

Black Hand
JoinedJan 1, 2002

Bug: Improper damage messages from dam_message
Danger: Medium - Damage values calculated incorrectly result in confusing messages
Found by: Luc
Fixed by: Luc


fight.c, dam_message

   short dampc;

Change to:
   int dampc;

Luc said:

On my PC this produce roughly one '**** SMITE ****' damage message out of four average, while they should be 4 on 4. The others are simple 'brushes' even if the damage causes the immediate death of the wolf. This may seem like a little thing, but its cause is a conceptual error: a short int variable in dam_message() has been employed to hold a value coming from an expression that can produce results far outside the 16 bits signed integer value range, so only the lower half of the result got stored. With some combinations of damage hps /victim hps the value stored for a successive consideration goes incorrectly negative.
Pages:<< prev 1 next >>