Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, Yahoo!

Members: 0
Guests: 7
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Memory leaks in load_mo...
Forum Rules | Mark all | Recent Posts

[Bug] Memory leaks in load_mobile during a hotboot
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Dec 25, 2006, 7:38 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Memory leaks in load_mobile during a hotboot
Danger: Medium - Memory leak. Can lead to other problems if left alone.
Found by: Remcon
Fixed by: Remcon

---

hotboot.c, load_mobile

Locate:
            KEY( "Description", mob->description, fread_string( fp ) );


Change to:
            if( !str_cmp( word, "Description" ) )
            {
               STRFREE( mob->description );
               mob->description = fread_string( fp );
               fMatch = TRUE;
               break;
            }


Locate:
            KEY( "Long", mob->long_descr, fread_string( fp ) );


Change to:
            if( !str_cmp( word, "Long" ) )
            {
               STRFREE( mob->long_descr );
               mob->long_descr = fread_string( fp );
               fMatch = TRUE;
               break;
            }


Locate:
            KEY( "Name", mob->name, fread_string( fp ) );


Change to:
            if( !str_cmp( word, "Name" ) )
            {
               STRFREE( mob->name );
               mob->name = fread_string( fp );
               fMatch = TRUE;
               break;
            }


Locate:
            KEY( "Short", mob->short_descr, fread_string( fp ) );


Change to:
            if( !str_cmp( word, "Short" ) )
            {
               STRFREE( mob->short_descr );
               mob->short_descr = fread_string( fp );
               fMatch = TRUE;
               break;
            }


Though minor, memory leaks can still cause other problems if not dealt with. Best not to ignore them when found.
       
Pages:<< prev 1 next >>