Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, DotBot, Google, Yandex

Members: 0
Guests: 17
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
632
ClarenceKe
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] do_clone removed bestow...
Forum Rules | Mark all | Recent Posts

[Bug] do_clone removed bestowments incorrectly
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 29, 2006, 1:58 pm   Last edited Nov 23, 2006, 8:10 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: do_clone removed bestowments incorrectly
Danger: Medium - String data corruption. Possible crash.
Found by: Guido
Fixed by: Keberus

---

misc.c, do_clone

Locate:
   if( ch->pcdata->clan_name && ch->pcdata->clan_name[0] != '\0' )
   {
      strcpy( clanname, ch->pcdata->clan_name );
      STRFREE( ch->pcdata->clan_name );
      ch->pcdata->clan_name = STRALLOC( "" );
      if( ch->pcdata->bestowments )
      {
         strcpy( bestowments, ch->pcdata->bestowments );
         STRFREE( ch->pcdata->bestowments );
         ch->pcdata->bestowments = STRALLOC( "" );
      }
      save_clone( ch );
      STRFREE( ch->pcdata->clan_name );
      ch->pcdata->clan_name = STRALLOC( clanname );
      if( bestowments[0] != '\0' )
      {
         STRFREE( ch->pcdata->bestowments );
         ch->pcdata->bestowments = STRALLOC( bestowments );
      }
   }


Change to:
   if( ch->pcdata->clan_name && ch->pcdata->clan_name[0] != '\0' )
   {
      strcpy( clanname, ch->pcdata->clan_name );
      STRFREE( ch->pcdata->clan_name );
      ch->pcdata->clan_name = STRALLOC( "" );
      if( ch->pcdata->bestowments )
      {
         strcpy( bestowments, ch->pcdata->bestowments );
         DISPOSE( ch->pcdata->bestowments );
         ch->pcdata->bestowments = str_dup( "" );
      }
      save_clone( ch );
      STRFREE( ch->pcdata->clan_name );
      ch->pcdata->clan_name = STRALLOC( clanname );
      if( bestowments[0] != '\0' )
      {
         DISPOSE( ch->pcdata->bestowments );
         ch->pcdata->bestowments = str_dup( bestowments );
      }
   }


Yet another classic STRALLOC/DISPOSE mismatch.
       
Pages:<< prev 1 next >>