Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing

Members: 0
Guests: 11
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,387
627
MargoThurb
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SWFOTE FUSS » Fwrite_obj ...doesn't check a...
Forum Rules | Mark all | Recent Posts

Fwrite_obj ...doesn't check against null obj_data
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 25, 2006, 3:41 pm
Go to the top of the page
Go to the bottom of the page

Keberus
Conjurer
GroupFUSS Project Team
Posts341
JoinedJun 4, 2005

I was wondering if fwrite_obj purposely overlooks null obj data or it should be checked. Phoneix Dracul had a core dump that pointed to this code being called on null obj_data, so it crashed his mud. The fix is simple.

The fix, in save.c fwrite_obj

after:
   if( iNest >= MAX_NEST )
   {
      bug( "fwrite_obj: iNest hit MAX_NEST %d", iNest );
      return;
   }


add:
   if( !obj )
   {
      bug( "%s", "fwrite_obj: NULL obj" );
      return;
   }


Just seems kinda obvious. I wonder why it was always overlooked?

Later,
KeB
       
Pages:<< prev 1 next >>