Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, Yahoo!

Members: 0
Guests: 4
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Port numbers sometimes ...
Forum Rules | Mark all | Recent Posts

[Bug] Port numbers sometimes show up in logs with negative values
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 30, 2006, 7:41 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Port numbers sometimes show up in logs with negative values
Danger: Trivial - Display only bug.
Found by: Remcon
Fixed by: Remcon

---

comm.c, new_descriptor

Locate:
   log_printf_plus( LOG_COMM, sysdata.log_level, "Sock.sinaddr:  %s, port %hd.", buf, dnew->port );


Change to:
   log_printf_plus( LOG_COMM, sysdata.log_level, "Sock.sinaddr:  %s, port %d.", buf, dnew->port );


This is a very subtle one to spot, but it makes all the difference when displaying the value. %hd is the formatting tag for a signed short, while %d is the formatting tag for an int. Since port numbers can go to 65535, a signed short isn't the proper size to display it.
       
Pages:<< prev 1 next >>