Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing

Members: 0
Guests: 9
Stats
Files
Topics
Posts
Members
Newest Member
481
3,739
19,386
625
OmarHarrim
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Introduction code has b...
Forum Rules | Mark all | Recent Posts

[Bug] Introduction code has bad name pointer handling
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 30, 2006, 7:21 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: Introduction code has bad name pointer handling
Danger: Critical - High probability of crashing with NULL pointers.
Found by: Phoenix Dracul
Fixed by: Keberus

---

act_info.c, do_introduce

Locate:
   CREATE( fellow, FELLOW_DATA, 1 );
   fellow->victim = ch->name;
   fellow->knownas = STRALLOC( argument );
   LINK( fellow, victim->first_fellow, victim->last_fellow, next, prev );


Change to:
   CREATE( fellow, FELLOW_DATA, 1 );
   fellow->victim = QUICKLINK( ch->name );
   fellow->knownas = STRALLOC( argument );
   LINK( fellow, victim->first_fellow, victim->last_fellow, next, prev );


act_info.c, do_remember

Locate:
   CREATE( nfellow, FELLOW_DATA, 1 );
   nfellow->victim = victim->name;
   nfellow->knownas = STRALLOC( argument );
   LINK( nfellow, ch->first_fellow, ch->last_fellow, next, prev );


Change to:
   CREATE( nfellow, FELLOW_DATA, 1 );
   nfellow->victim = QUICKLINK( victim->name );
   nfellow->knownas = STRALLOC( argument );
   LINK( nfellow, ch->first_fellow, ch->last_fellow, next, prev );


act_info.c, do_describe

Locate:
         CREATE( nfellow, FELLOW_DATA, 1 );
         nfellow->victim = fellow->victim;
         nfellow->knownas = fellow->knownas;
         LINK( nfellow, victim->first_fellow, victim->last_fellow, next, prev );


Change to:
         CREATE( nfellow, FELLOW_DATA, 1 );
         nfellow->victim = QUICKLINK( victim->name );
         nfellow->knownas = STRALLOC( argument );
         LINK( nfellow, ch->first_fellow, ch->last_fellow, next, prev );


With the way the nfellow->victim field was being assigned, it pointed directly to the same thing as the other player's name. when that person leaves the game the nfellow pointer now holds invalid data in it which will cause a crash the moment it's accessed.
       
Pages:<< prev 1 next >>