Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, Bing, Majestic-12, Sogou

Members: 0
Guests: 8
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Mismatched memory macro...
Forum Rules | Mark all | Recent Posts

[Bug] Mismatched memory macros in obj->killer code
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 30, 2006, 6:30 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Mismatched memory macros in obj->killer code
Danger: Medium - Leads to memory leakage and corrupted strings.
Found by: Keberus
Fixed by: Keberus

---

makeobjs.c, make_corpse

Locate:
   if( corpse->killer )
      STRFREE( corpse->killer );
   corpse->killer = str_dup( killer );


Change to:
   if( corpse->killer )
      DISPOSE( corpse->killer );
   corpse->killer = str_dup( killer );


handler.c, free_obj

Locate:
   STRFREE( obj->short_descr );
   STRFREE( obj->action_desc );
   DISPOSE( obj );


Change to:
   STRFREE( obj->short_descr );
   STRFREE( obj->action_desc );
   DISPOSE( obj->killer );
   DISPOSE( obj );


Some more of the classic mismatching between STRFREE and DISPOSE. Along with a classic memory leak of forgetting to free up data which was added to the structure.
       
Pages:<< prev 1 next >>