Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Yandex, Sogou

Members: 0
Guests: 18
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
632
ClarenceKe
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] do_fset and do_fhset do...
Forum Rules | Mark all | Recent Posts

[Bug] do_fset and do_fhset do not clean up all necessary strings
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 10, 2006, 12:24 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: do_fset and do_fhset do not clean up all necessary strings
Danger: High - Memory leak with possible corruption
Found by: Keberus
Fixed by: Keberus

---

force.c

Locate:
#include <errno.h>
#include "mud.h"


Below that, add:
void free_forceskill( FORCE_SKILL * fskill )
{
   short x;

   if( !fskill )
   {
      bug( "%s: null forceskill pointer!", __FUNCTION__ );
      return;
   }
     
   STRFREE( fskill->name );
   STRFREE( fskill->code );

   for( x = 0; x < 5; x++ )
   {
      STRFREE( fskill->room_effect[x] );
      STRFREE( fskill->victim_effect[x] );
      STRFREE( fskill->ch_effect[x] );
   }
   DISPOSE( fskill );
   return;
}

void free_forcehelp( FORCE_HELP * fhelp )
{
   if( !fhelp )
   {
      bug( "%s: null forcehelp pointer!", __FUNCTION__ );
      return;
   }

   STRFREE( fhelp->desc );
   STRFREE( fhelp->name );

   DISPOSE( fhelp );
   return;
}


force.c, do_fset

Locate:
      else if( !strcmp( arg2, "remove" ) )
      {
         UNLINK( fskill, first_force_skill, last_force_skill, next, prev );
         write_all_forceskills(  );
         send_to_char( "Done.\r\n", ch );
         return;
      }


Change to:
      else if( !strcmp( arg2, "remove" ) )
      {
         UNLINK( fskill, first_force_skill, last_force_skill, next, prev );
         free_forceskill( fskill );
         write_all_forceskills(  );
         send_to_char( "Done.\r\n", ch );
         return;
      }


force.c, do_fhset

Locate:
      else if( !strcmp( arg3, "remove" ) )
      {
         UNLINK( fhelp, first_force_help, last_force_help, next, prev );
         write_all_forcehelps(  );
         send_to_char( "Done.\r\n", ch );
         return;
      }


Change to:
      else if( !strcmp( arg3, "remove" ) )
      {
         UNLINK( fhelp, first_force_help, last_force_help, next, prev );
         free_forcehelp( fhelp );
         write_all_forcehelps(  );
         send_to_char( "Done.\r\n", ch );
         return;
      }


And yet another case of not cleaning up after deallocating something. This time leaving behind pretty much everything these two commands can create.
       
Pages:<< prev 1 next >>