Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, DotBot, Bing

Members: 0
Guests: 12
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
633
Rhyader
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] do_remclan does not cle...
Forum Rules | Mark all | Recent Posts

[Bug] do_remclan does not clean up all necessary strings
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 10, 2006, 12:17 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: do_remclan does not clean up all necessary strings
Danger: High - Memory leak with possible corruption
Found by: Keberus
Fixed by: Keberus

---

clans.c, do_remclan

Replace that function with:
void free_clan( CLAN_DATA * clan )
{
   STRFREE( clan->acro );
   STRFREE( clan->filename );
   STRFREE( clan->shortname );
   STRFREE( clan->name );
   STRFREE( clan->description );
   STRFREE( clan->leader );
   STRFREE( clan->number1 );
   STRFREE( clan->number2 );
   STRFREE( clan->atwar );
   STRFREE( clan->tmpstr );
   DISPOSE( clan );
}

void do_remclan( CHAR_DATA * ch, char *argument )
{
   CLAN_DATA *clan;

   if( ( clan = get_clan( argument ) ) == NULL )
   {
      send_to_char( "No such clan.\r\n", ch );
      return;
   }

   UNLINK( clan, first_clan, last_clan, next, prev );
   free_clan( clan );
   write_clan_list(  );
}


Yet another case of strings left behind after the memory was supposed to be freed.
       
Pages:<< prev 1 next >>