Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, DotBot, Yandex

Members: 0
Guests: 19
Stats
Files
Topics
Posts
Members
Newest Member
481
3,739
19,386
619
Alexander
Today's Birthdays
Scaythe (46)
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] free_char does not clea...
Forum Rules | Mark all | Recent Posts

[Bug] free_char does not clean up all necessary strings
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 10, 2006, 12:14 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: free_char does not clean up all necessary strings
Danger: High - Memory leak with possible corruption
Found by: Keberus
Fixed by: Keberus

---

db.c, free_char

Locate:
   while( ( bugs = ch->first_bug ) != NULL )
   {
      UNLINK( bugs, ch->first_bug, ch->last_bug, next_in_bug, prev_in_bug );
      DISPOSE( bugs );
   }

   while( ( contract = ch->first_contract ) != NULL )
   {
      UNLINK( contract, ch->first_contract, ch->last_contract, next_in_contract, prev_in_contract );
      DISPOSE( contract );
   }

   while( ( fellow = ch->first_fellow ) != NULL )
   {
      UNLINK( fellow, ch->first_fellow, ch->last_fellow, next, prev );
      DISPOSE( fellow );
   }


Change to:
   while( ( bugs = ch->first_bug ) != NULL )
   {
      UNLINK( bugs, ch->first_bug, ch->last_bug, next_in_bug, prev_in_bug );
      STRFREE( bugs->name );
      DISPOSE( bugs );
   }

   while( ( contract = ch->first_contract ) != NULL )
   {
      UNLINK( contract, ch->first_contract, ch->last_contract, next_in_contract, prev_in_contract );
      DISPOSE( contract->target );
      DISPOSE( contract );
   }

   while( ( fellow = ch->first_fellow ) != NULL )
   {
      UNLINK( fellow, ch->first_fellow, ch->last_fellow, next, prev );
      STRFREE( fellow->knownas );
      STRFREE( fellow->victim );
      DISPOSE( fellow );
   }


Dangling strings left behind in memory when each player quits/logs out etc and is extracted from the game. Leaving these things behind eventually results in resource draining and can lead to data corruption in extreme cases.
       
Pages:<< prev 1 next >>