Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing

Members: 0
Guests: 19
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
640
KieraZajac
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWR FUSS Bugfix List » [Bug] Invis command does not ...
Forum Rules | Mark all | Recent Posts

[Bug] Invis command does not verify NPC status for ch->act flag
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 10, 2006, 1:02 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: Invis command does not verify NPC status for ch->act flag
Danger: Trivial - Mobs using this command will alter the ACT_POLYSELF flag, which is not used.
Found by: Kiasyn
Fixed by: Kiasyn

---

act_wiz.c, do_invis

Locate:
   if( !IS_NPC( ch ) )
   {
      if( ch->pcdata->wizinvis < 2 )
         ch->pcdata->wizinvis = ch->top_level;
   }

   if( IS_NPC( ch ) )
   {
      if( ch->mobinvis < 2 )
         ch->mobinvis = ch->top_level;
   }


Change to:
   if( IS_NPC( ch ) )
   {
      if( ch->mobinvis < 2 )
         ch->mobinvis = ch->top_level;
      return;
   }

   if( ch->pcdata->wizinvis < 2 )
      ch->pcdata->wizinvis = ch->top_level;


The invis command allowed NPCs to drop all the way to the final check in the code which plays with the PLR_WIZINVIS flag. Since NPCs and players share the ch->act field, this would have had mobs checking and messing with the ACT_POLYSELF flag. This flag is unused in stock but might get replaced with something else.
       
Pages:<< prev 1 next >>