Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl

Members: 0
Guests: 18
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
632
ClarenceKe
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Lever position ifcheck ...
Forum Rules | Mark all | Recent Posts

[Bug] Lever position ifcheck doesn't work properly
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Aug 27, 2006, 8:25 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: Lever position ifcheck doesn't work properly
Danger: Low - State of functional levers, pullchains, switches, and buttons can't be checked
Found by: Remcon
Fixed by: Remcon

---

mud_prog.c, mprog_do_ifcheck

Locate:
      if( !str_cmp( chck, "leverpos" ) )
      {
         int isup = FALSE, wantsup = FALSE;
         if( chkobj->item_type != ITEM_SWITCH || chkobj->item_type != ITEM_LEVER || chkobj->item_type != ITEM_PULLCHAIN )
            return FALSE;

         if( IS_SET( obj->value[0], TRIG_UP ) )
            isup = TRUE;
         if( !str_cmp( rval, "up" ) )
            wantsup = TRUE;
         return mprog_veval( wantsup, opr, isup, mob );
      }


Change to:
      if( !str_cmp( chck, "leverpos" ) )
      {
         int isup = FALSE, wantsup = FALSE;

         if( chkobj->item_type != ITEM_SWITCH && chkobj->item_type != ITEM_LEVER && chkobj->item_type != ITEM_PULLCHAIN && chkobj->item_type != ITEM_BUTTON )
            return FALSE;

         if( IS_SET( obj->value[0], TRIG_UP ) )
            isup = TRUE;
         if( !str_cmp( rval, "up" ) )
            wantsup = TRUE;

         return mprog_veval( wantsup, opr, isup, mob );
      }


This ifcheck should only let 4 items times get passed it, so it needs to do an AND comparison. Not an OR comparison. Otherwise the check is somewhat useless.
       
Pages:<< prev 1 next >>