Bug: Action descriptions will reveal invisible players
Danger: Medium - Invisible players can be identified by using an item with an action description attached.
Found by: Dragona
Fixed by: Remcon

---

misc.c, actiondesc

Locate:

      else if( *srcptr == '%' && *++srcptr == 's' )
      {
         ichar = "You";
         iroom = IS_NPC( ch ) ? ch->short_descr : ch->name;
      }

Change to:

      else if( *srcptr == '%' && *++srcptr == 's' )
      {
         ichar = "You";
         iroom = "$n";
      }

This is an obscure corner bug but one that would become more obvious on muds that make use of the action descriptions on items. The unfixed code would just attach the name of the NPC or player who performed the action regardless of their invisibility state. Since the variables in this function are eventually passed to act(), changing to $n will allow act() to take care of checking for invisibility and using the "Someone" name where appropriate.