Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Google

Members: 0
Guests: 8
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
614
BenitoVirg
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Action descriptions wil...
Forum Rules | Mark all | Recent Posts

[Bug] Action descriptions will reveal invisible players
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Aug 19, 2006, 2:29 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Action descriptions will reveal invisible players
Danger: Medium - Invisible players can be identified by using an item with an action description attached.
Found by: Dragona
Fixed by: Remcon

---

misc.c, actiondesc

Locate:
      else if( *srcptr == '%' && *++srcptr == 's' )
      {
         ichar = "You";
         iroom = IS_NPC( ch ) ? ch->short_descr : ch->name;
      }


Change to:
      else if( *srcptr == '%' && *++srcptr == 's' )
      {
         ichar = "You";
         iroom = "$n";
      }


This is an obscure corner bug but one that would become more obvious on muds that make use of the action descriptions on items. The unfixed code would just attach the name of the NPC or player who performed the action regardless of their invisibility state. Since the variables in this function are eventually passed to act(), changing to $n will allow act() to take care of checking for invisibility and using the "Someone" name where appropriate.
       
Pages:<< prev 1 next >>