Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing

Members: 0
Guests: 11
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
633
Rhyader
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Deleting a project may ...
Forum Rules | Mark all | Recent Posts

[Bug] Deleting a project may corrupt memory while deleting log pointers
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Aug 19, 2006, 1:08 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: Deleting a project may corrupt memory while deleting log pointers
Danger: High - Corrupted project logs could result in a crash
Found by: Remcon
Fixed by: Samson

---

boards.c, delete_project

Locate:
   nlog = project->last_log;
   while( nlog )
   {
      UNLINK( nlog, project->first_log, project->last_log, next, prev );
      tlog = nlog->prev;
      free_note( nlog );
      nlog = tlog;
   }


Change to:
   for( nlog = project->first_log; nlog; nlog = tlog )
   {
      tlog = nlog->next;

      UNLINK( nlog, project->first_log, project->last_log, next, prev );
      free_note( nlog );
   }


The project log deletion does some oddball things with the memory pointers. The while loop may look sound, but it could actually result in screwing up the wrong logs, and its intention isn't entirely clear. Changing to the for loop solves the problem and is also easier to follow for future maintenance.
       
Pages:<< prev 1 next >>