Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl

Members: 0
Guests: 16
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,388
628
PabloL3189
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Action descriptions wil...
Forum Rules | Mark all | Recent Posts

[Bug] Action descriptions will reveal invisible players
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Aug 13, 2006, 8:42 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: Action descriptions will reveal invisible players
Danger: Medium - Invisible players can be identified by using an item with an action description attached.
Found by: Dragona
Fixed by: Remcon

---

misc.c, actiondesc

Locate:
      else if( *srcptr == '%' && *++srcptr == 's' )
      {
         ichar = "You";
         iroom = IS_NPC( ch ) ? ch->short_descr : ch->name;
      }


Change to:
      else if( *srcptr == '%' && *++srcptr == 's' )
      {
         ichar = "You";
         iroom = "$n";
      }


This is an obscure corner bug but one that would become more obvious on muds that make use of the action descriptions on items. The unfixed code would just attach the name of the NPC or player who performed the action regardless of their invisibility state. Since the variables in this function are eventually passed to act(), changing to $n will allow act() to take care of checking for invisibility and using the "Someone" name where appropriate.
       
Pages:<< prev 1 next >>