Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing

Members: 0
Guests: 22
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
634
BlaineNock
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] String checking argumen...
Forum Rules | Mark all | Recent Posts

[Bug] String checking arguments reversed
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Aug 13, 2006, 7:55 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: String checking arguments reversed
Danger: Low - Comparisons made are backward. Doesn't post overly large threat.
Found by: Remcon
Fixed by: Remcon/Mordecai

---

imm_host.c, check_immortal_domain

Locate:
         if( temp->prefix && temp->suffix && strstr( temp->host, my_host ) )
            return TRUE;


Change to:
         if( temp->prefix && temp->suffix && strstr( my_host, temp->host ) )
            return TRUE;


act_wiz.c, do_ipcompare

Locate:
      if( prefix && suffix && strstr( addie, d->host ) )
         fMatch = TRUE;


Change to:
      if( prefix && suffix && strstr( d->host, addie ) )
         fMatch = TRUE;


ban.c, check_total_bans

Locate:
      if( pban->level != LEVEL_SUPREME )
         continue;
      if( pban->prefix && pban->suffix && strstr( pban->name, new_host ) )


Change to:
      if( pban->level != LEVEL_SUPREME )
         continue;
      if( pban->prefix && pban->suffix && strstr( new_host, pban->name ) )


All of the above are classic cases of strstr being called with its arguments in a reversed order. Usually resulting in a failed check but not often having any dangerous side affects.
       
Pages:<< prev 1 next >>