Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing

Members: 0
Guests: 17
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
640
KieraZajac
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Skills not freeing all ...
Forum Rules | Mark all | Recent Posts

[Bug] Skills not freeing all required information
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 May 27, 2006, 9:54 am   Last edited May 27, 2006, 10:00 am by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: Skills not freeing all required information
Danger: Trivial - Memory leak: spell_fun_name and skill_fun_name need to be freed
Found by: Remcon
Fixed by: Remcon

---

skills.c, free_skill

Locate:
   DISPOSE( skill->imm_char );
   DISPOSE( skill->imm_vict );
   DISPOSE( skill->imm_room );
   DISPOSE( skill->dice );


Below that, add:
   if( skill->spell_fun_name )
      DISPOSE( skill->spell_fun_name );
   if( skill->skill_fun_name )
      DISPOSE( skill->skill_fun_name );


Even though this is technically a memory leak bug, the free_skill function is only called at shutdown during the cleanup_memory process. Otherwise this will have no impact, unless you've modified your code to allow skills to be deleted online.
       
Pages:<< prev 1 next >>