Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing, DotBot

Members: 0
Guests: 10
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
633
Rhyader
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Color theme file is not...
Forum Rules | Mark all | Recent Posts

[Bug] Color theme file is not closed properly in an error condition
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 May 13, 2006, 2:28 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: Color theme file is not closed properly in an error condition
Danger: Medium - Leaves file descriptors hanging open
Found by: Halcyon
Fixed by: Halcyon

---

color.c, do_color

Locate:
      ch_printf( ch, "An error occured while trying to set color theme %s.\r\n", argument );
      return;


Change to:
      fclose( fp );
      fp = NULL;
      ch_printf( ch, "An error occured while trying to set color theme %s.\r\n", argument );
      return;


If a color theme file reaches EOF prematurely, then the file is not closing out properly. Leaving enough files dangling open can cause resource shortages and in general just creates problems.
       
Pages:<< prev 1 next >>