Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, DotBot, Bing

Members: 0
Guests: 19
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
640
KieraZajac
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] IS_DEADLYCLAN macro has...
Forum Rules | Mark all | Recent Posts

[Bug] IS_DEADLYCLAN macro has too many parentheses
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 13, 2006, 4:15 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: IS_DEADLYCLAN macro has too many parentheses
Danger: Trivial - The macro isn't actually being used yet
Found by: Remcon
Fixed by: Remcon

---

skills.c, do_rescue

Locate:
#define IS_DEADLYCLAN(ch)    (!IS_NPC((ch))                    \
                && (ch)->pcdata->clan                \
                && (ch)->pcdata->clan->clan_type != CLAN_NOKILL) \
                && (ch)->pcdata->clan->clan_type != CLAN_ORDER)  \
                && (ch)->pcdata->clan->clan_type != CLAN_GUILD)


Change to:
#define IS_DEADLYCLAN(ch)    (!IS_NPC((ch))                    \
                && (ch)->pcdata->clan                \
                && (ch)->pcdata->clan->clan_type != CLAN_NOKILL \
                && (ch)->pcdata->clan->clan_type != CLAN_ORDER  \
                && (ch)->pcdata->clan->clan_type != CLAN_GUILD)


The above macro has too many parentheses in it. Though one might wonder why the compiler hasn't seen this before now, the answer is relatively simple. Macros are not expanded until they are actualy used in a C file somewhere. At that point, the macro would be replaced with the code it's defined as, and then it would promptly stop the compile with a parse error that might be somewhat confusing. This macro is never actually used in the code so it can be safely removed if desired.
       
Pages:<< prev 1 next >>