User Name:


Forgot your password?
Vote for Us!
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, DotBot, Bing

Members: 0
Guests: 17
Newest Member
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Line editor input not c...
Forum Rules | Mark all | Recent Posts

[Bug] Line editor input not consistent with file I/O behaviour
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Jan 30, 2006, 3:13 pm   Last edited Feb 4, 2006, 6:06 pm by Samson
Go to the top of the page
Go to the bottom of the page

Black Hand
JoinedJan 1, 2002

Bug: Line editor input not consistent with file I/O behaviour
Danger: Medium - Will break any mudprog entered via OLC before the mud reboots.
Found by: Stan
Fixed by: Samson


build.c, copy_buffer

         mudstrlcat( tmp, "\r\n", 100 );

Change to:
         mudstrlcat( tmp, "\n", 100 );

Replace the same line in copy_buffer_nohash.

If you have not yet applied the mudstrlcpy/cat functions, then look for:

	strcat( tmp, "\r\n" );

And change it to:
	strcat( tmp, "\n" );

If you have not yet done the telnet protocol fix where \n\r is replaced with \r\n, you won't be affected by the bug but should probably still fix it anyway.

This is one of those stupid things that even after looking at it and banging heads against walls still fails to make alot of sense, but nonetheless, having the line editor only use \n (LF) to signify a newline seems to be the proper solution to this. Since mudprogs are saved to disk with \r (CR) stripped the behaviour of the line editor now properly follows the same standard used by the file I/O systems. And it can never hurt anything to use consistent behaviour, right? We've just seen what happens when you don't!
Pages:<< prev 1 next >>