Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Majestic-12, Yandex

Members: 0
Guests: 13
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,388
628
PabloL3189
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWR FUSS Bugfix List » [Bug] Some of the stat retrei...
Forum Rules | Mark all | Recent Posts

[Bug] Some of the stat retreival functions do not initialize properly
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Jan 22, 2006, 4:26 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: Some of the stat retreival functions do not initialize properly
Danger: Medium - Working with uninitialized values is undefined and probably not what you want.
Found by: Valgrind
Fixed by: Samson

---

handler.c

Locate:
/*
 * Retrieve character's current dexterity.
 */
short get_curr_dex( CHAR_DATA * ch )
{
   short max;
   max = UMIN( max, 25 );

   max = 20 + race_table[ch->race].dex_plus;

   return URANGE( 3, ch->perm_dex + ch->mod_dex, max );
}

/*
 * Retrieve character's current constitution.
 */
short get_curr_con( CHAR_DATA * ch )
{
   short max;
   max = UMIN( max, 25 );

   max = 20 + race_table[ch->race].con_plus;

   return URANGE( 3, ch->perm_con + ch->mod_con, max );
}

/*
 * Retrieve character's current charisma.
 */
short get_curr_cha( CHAR_DATA * ch )
{
   short max;
   max = UMIN( max, 25 );

   max = 20 + race_table[ch->race].cha_plus;

   return URANGE( 3, ch->perm_cha + ch->mod_cha, max );
}


Change to:
/*
 * Retrieve character's current dexterity.
 */
short get_curr_dex( CHAR_DATA * ch )
{
   short max;

   max = 20 + race_table[ch->race].dex_plus;
   max = UMIN( max, 25 );

   return URANGE( 3, ch->perm_dex + ch->mod_dex, max );
}

/*
 * Retrieve character's current constitution.
 */
short get_curr_con( CHAR_DATA * ch )
{
   short max;

   max = 20 + race_table[ch->race].con_plus;
   max = UMIN( max, 25 );

   return URANGE( 3, ch->perm_con + ch->mod_con, max );
}

/*
 * Retrieve character's current charisma.
 */
short get_curr_cha( CHAR_DATA * ch )
{
   short max;

   max = 20 + race_table[ch->race].cha_plus;
   max = UMIN( max, 25 );

   return URANGE( 3, ch->perm_cha + ch->mod_cha, max );
}


The 3 functions above are used in a number of calculations throughout the game and can have serious side affects if the system uses the uninitalized max value and ends up thinking it should be 25 instead of what it really is.
       
Pages:<< prev 1 next >>