Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing

Members: 0
Guests: 8
Stats
Files
Topics
Posts
Members
Newest Member
481
3,739
19,386
627
MargoThurb
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Site bans are not being...
Forum Rules | Mark all | Recent Posts

[Bug] Site bans are not being linked to the banlist
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Dec 18, 2005, 1:05 pm   Last edited Dec 18, 2005, 1:09 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: Site bans are not being linked to the banlist.
Danger: High - Entered ban data is unusable. Memory is leaked.
Found by: Remcon
Fixed by: Remcon

---

ban.c, add_ban

Locate:
               CREATE( pban, BAN_DATA, 1 );
               pban->ban_by = str_dup( ch->name );
               pban->suffix = suffix;
               pban->prefix = prefix;
               pban->name = str_dup( name );
               pban->level = level;
               if( user_name )
               {
                  DISPOSE( temp_host );
                  DISPOSE( temp_user );
               }
               break;


Change to:
               CREATE( pban, BAN_DATA, 1 );
               pban->ban_by = str_dup( ch->name );
               pban->suffix = suffix;
               pban->prefix = prefix;
               pban->name = str_dup( name );
               pban->level = level;
               LINK( pban, first_ban, last_ban, next, prev );
               if( user_name )
               {
                  DISPOSE( temp_host );
                  DISPOSE( temp_user );
               }
               break;


This one is just a straightforward forgetfulness error on the part of Remcon. Tsk tsk. Failing to link the ban data to the list effectively means you never banned the site since it's not in the list to be checked. It also means that once created, the ban memory is leaked. The leak is very limited though since you must first attempt to ban a site.
       
Pages:<< prev 1 next >>