Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Google, Yandex

Members: 0
Guests: 9
Stats
Files
Topics
Posts
Members
Newest Member
481
3,734
19,366
618
Micheal64X
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » General » General Discussions » Smaug Buffer Bug
Forum Rules | Mark all | Recent Posts

Smaug Buffer Bug
< Newer Topic :: Older Topic > Line/Size Limits and Crashing

Pages:<< prev 1 next >>
* #1 Nov 29, 2005, 5:47 pm
Go to the top of the page
Go to the bottom of the page

Banner
Magician
GroupMembers
Posts169
JoinedNov 29, 2005

First post here, and I'm unsure if this issue has been addressed or not, and if it has, please point me in the right direction. Now. Recently players have been trying to put in huge bios that overshot the stock 50 line limit. Poking around I changed max_buf_lines to equal 90, and another ifcheck that had a limit of 49, and the limit in editor_data struct in mud.h. I may have messed with memory size limits and not set them back right to inflict this upon myself, but I am unsure. Posting one line into a buffer that is at 90 lines(only tested it with biographies), it will send "Buffer Full" and knock you out. But trying to post two+ lines into a buffer, it crashes the MUD so it must be restarted manually. I beleive players are abusing it and it seems like a very bad bug. Please help me find or fix this if you can. Thanks for your time.

I can give you any other information you need if this isn't enough. Thanks
AIM: SystmFrz
       
Post is unread #2 Nov 29, 2005, 6:52 pm
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,873
JoinedJul 26, 2005

Give us some info like what it is you put in etc...
If it produces a core file a backtrace of whats in the core would also be of use.
If you know how to use valgrind that also might catch possible issues causing this issue.
And you said that "Posting one line into a buffer that is at 90 lines( Only tested it with biographies) it will send "Buffer Full" and knock you out."
So that means that if you tried to do a 91 line it would do that?
But if you tried to do a 92 line bio it would crash?
Just trying to get a little more info on this deal lol.
       
Post is unread #3 Nov 29, 2005, 7:00 pm
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,873
JoinedJul 26, 2005

Just to test it out on mine I did a 96 line bio. (Using copy and pasteing the full 96 lines at one time)
Once it got to line 25 (it said buffer full and closed it out correctly) Then for each of the other lines
that I had pasted it just said huh each time. So I doubt stock has this issue since I don't recall having changed
any of the things to do with that anywhere.
       
Post is unread #4 Nov 29, 2005, 8:20 pm
Go to the top of the page
Go to the bottom of the page

Gatz
Apprentice
GroupMembers
Posts60
JoinedJul 25, 2005

I had this issue once myself, I changed MAX_STRING_LENGTH in mud.h and that fixed the problem. I just multipled the old one by 2 and saw it go away, multiple by 2 as many times depending on how big you wanted the buffer to be. I assume your issue is just an array out of bounds problem.
       
Post is unread #5 Nov 29, 2005, 8:25 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Carelessly raising MAX_STRING_LENGTH won't solve this - that is going to eat up alot of memory. What's most likely needed is for the particular functions to be checked for bufer safety. It sounds to me like they aren't and that is what's causing the crash.
       
Post is unread #6 Nov 29, 2005, 9:37 pm
Go to the top of the page
Go to the bottom of the page

Gatz
Apprentice
GroupMembers
Posts60
JoinedJul 25, 2005

I edited out my thing about that before I submitted it, thanks for mentioning that Samson. However, if you didn't want to raise MSL (MAX_STRING_LENGTH) then you'd probably have to use something new for your buffers.
       
Post is unread #7 Nov 30, 2005, 4:02 am
Go to the top of the page
Go to the bottom of the page

Banner
Magician
GroupMembers
Posts169
JoinedNov 29, 2005

Ah, I considered the project a failure and installed a new editor I'd been searching for. I did raise MAX_STRING_LENGTH and after realizing that probably wouldn't be a good idea, I set it back. Someone told me it'd probably be to much work than its worth to try to make the original stock buffer support more information, so using the new one seemed like the best idea and it offered more features, and used MAX_STRING_LENGTH as the buffer limit, which seemed like a good idea to me so yeah. Thanks anyway, and I appreciate the help you attempted to give me even on behalf of my lack of information.
       
Pages:<< prev 1 next >>