Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl

Members: 0
Guests: 8
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,396
629
DarrenPayn
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] strip_cr function has n...
Forum Rules | Mark all | Recent Posts

[Bug] strip_cr function has no protection against NULL strings
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Nov 6, 2005, 1:51 pm   Last edited Nov 27, 2005, 2:03 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: strip_cr function has no protection against NULL strings
Danger: Critical - Can lead to crashes and corrupted data.
Found by: Samson
Fixed by: Samson

---

build.c, strip_cr

Locate:
   static char newstr[MAX_STRING_LENGTH];
   int i, j;


Change to:
   static char newstr[MAX_STRING_LENGTH];
   int i, j;

   if( !str || str[0] == '\0' )
      return "";


This simple fix will prevent the strip_cr function from bringing the game down at a most inopportune moment with a NULL string being fed to it. This function is used heavily in the saving of area files so it represents an especially dangerous threat if left unprotected. When fed a NULL string this fix will return just an empty one which is perfectly safe.

EDIT: This fix was edited to remove the bug message due to spam reports. The NULL string protection is still vital however and should not be removed completely.
       
Pages:<< prev 1 next >>