Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Sogou

Members: 0
Guests: 13
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
632
ClarenceKe
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] immune_casting checks w...
Forum Rules | Mark all | Recent Posts

[Bug] immune_casting checks wrong variable when missing a character
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Jul 30, 2005, 8:53 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: immune_casting checks wrong variable when missing a character.
Danger: Medium - NULL string access, bug message
Found by: Zeno
Fixed by: Zeno

---

magic.c, immune_casting

Locate:
      else if( skill->miss_char && skill->miss_char[0] != '\0' )
         act( chit, skill->hit_char, ch, obj, victim, TO_CHAR );


Replace with:

      else if( skill->miss_char && skill->miss_char[0] != '\0' )
         act( chit, skill->miss_char, ch, obj, victim, TO_CHAR );


This code is used again a bit further down in the function and needs to be fixed there too.

Because this part of the function is checking the wrong pointer, it can lead to string comparison log messages, and possible crashes due to a NULL string access. Obviously if it's checking miss_char, it should display the miss_char message.
       
Pages:<< prev 1 next >>