Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, DotBot

Members: 0
Guests: 13
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
632
ClarenceKe
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWR FUSS Bugfix List » [Bug] add_kill checks are not...
Forum Rules | Mark all | Recent Posts

[Bug] add_kill checks are not checking against PC victims
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Jul 30, 2005, 9:45 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: add_kill checks are not checking against PC victims
Danger: Low - Bug spam
Found by: Zeno
Fixed by: Gatewaysysop/Samson

---

fight.c, damage

Locate:
      else if( !IS_NPC( ch ) )   /* keep track of mob vnum killed */
         add_kill( ch, victim );

      /*
       * Add to kill tracker for grouped chars, as well. -Halcyon
       */
      for( gch = ch->in_room->first_person; gch; gch = gch->next_in_room )
         if( is_same_group( gch, ch ) && !IS_NPC( gch ) && gch != ch )
            add_kill( gch, victim );


Replace with:

      else if( !IS_NPC( ch ) && IS_NPC( victim ) )   /* keep track of mob vnum killed */
      {
         add_kill( ch, victim );

         /*
          * Add to kill tracker for grouped chars, as well. -Halcyon
          */
         for( gch = ch->in_room->first_person; gch; gch = gch->next_in_room )
            if( is_same_group( gch, ch ) && !IS_NPC( gch ) && gch != ch )
               add_kill( gch, victim );
      }


Halcyon's original fix to the add_kill problem failed to take PC victims into account and was passing them to the add_kill function which has a check to prevent PCs from being added to the kill tracking. This generated a bug message, correctly, to alert the imms of the problem.

Secondary note - this bug is a prime example of why these fixes need to be applied in the order they are posted in. This one depends on a previous FUSS fix.
       
Pages:<< prev 1 next >>